Fix: /back onto nether roof exploit when destination is unsafe. - #6602
Merged
Conversation
- Created crude `isAboveNetherRoof` safeguard for `getSafeDestination`.
JRoy
previously approved these changes
Aug 8, 2026
JRoy
approved these changes
Aug 8, 2026
JRoy
enabled auto-merge
August 8, 2026 20:45
Euphillya
added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Aug 13, 2026
EssentialsX@d2a7e0f Update paperVersion to 26.2.build.92-stable (EssentialsX#6575) EssentialsX@f6f13fd Show muted players' private messages to social spies (EssentialsX#6569) EssentialsX@382de4f Fix: /back onto nether roof exploit when destination is unsafe. (EssentialsX#6602)
wosnxn123
added a commit
to wosnxn123/Essentials-Folia
that referenced
this pull request
Aug 20, 2026
This reverts commit 1fcbec7. The bump was WRONG: 28eb89f ("Add toolchain auto download EssentialsX#6574", 2026-06-16) is not newer than 382de4f - it is a side-branch commit two months older, and 382de4f IS the current EssentialsX/Essentials 2.x tip (verified: git rev-parse origin/2.x == 382de4f, and rev-list 28eb89f..382de4f == 6 while 382de4f..28eb89f == 1). Root cause: I read 'git diff Essentials' backwards - the '-Subproject commit 382de4f' side was the correct COMMITTED pin and '+28eb89fb0' was a stale working-tree checkout, which I mistook for a new upstream. The build number falling from dev+37 to dev+31 was the signal that this was a downgrade, and I rationalised it instead of checking. The downgrade dropped six real upstream commits, including the /back nether-roof exploit fix (EssentialsX#6602), social-spy visibility of muted players' private messages (EssentialsX#6569), paperVersion 26.2.build.92-stable (EssentialsX#6575) and the cached online-user lookup optimisation (EssentialsX#6595).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #3318 and fixes #4483.
Details
Proposed fix:
isAboveNetherRoofsafeguard forgetSafeDestination.Environments tested:
OS: Linux (Server and Client)
Java version: 25
Most recent Paper version (XX.YY.Z, git-Paper-BUILD)CraftBukkit/Spigot/Paper 1.12.2CraftBukkit 1.8.8Demonstration:
Before:
2026-08-04_21-59-34.mp4
After:
2026-08-04_22-05-56.mp4